VoIPGRID / VialerSIPLib

An Objective-c wrapper for PJSIP
GNU General Public License v3.0
133 stars 69 forks source link

Fix for invite messages sent from Windows machine #191

Open kesslermichael opened 5 years ago

kesslermichael commented 5 years ago

Fix for invite messages sent from Windows machine (with \r\n new line characters instead of \n)

Issue number

{if exists provide related issue}

Expected behavior

Caller name should be parsed successfully from the invite message

Actual behavior

When the invite message arrives with \r\n new lines then it is not parsed properly - each parsed line ends with "\r". It causes the caller name not to be parsed because it doesn't match the corresponding regex in VSLCall.m:758 (the regex is '.+\\s<.+>')

Description of fix

Before the fix in SipInvite.m:89 the invite message was split to separate lines using "\n". The fix is to check whether the line separators in the invite message are "\r\n" and use it if so. Otherwise fallback to "\n".

Other info

{anything else that might be related/useful}

kesslermichael commented 5 years ago

@jeremynorman89 I agree that it might be improved. Specifically the linked suggestion may end up with irrelevant empty lines in case of "\r\n" new line sign (like in my case). It can be fixed by filtering out empty lines though.

jeremynorman89 commented 5 years ago

I think that would be a better solution still, even if you need to filter empty lines out.

ChrisKontosEU commented 4 years ago

Any updates for this MR?