VoIPGRID / VialerSIPLib

An Objective-c wrapper for PJSIP
GNU General Public License v3.0
133 stars 69 forks source link

PJSUA_IP_CHANGE_OP_COMPLETED Error #206

Open mudassirzulfiqar opened 4 years ago

mudassirzulfiqar commented 4 years ago

Version

{3.7.0}

File / Feature

{VSLEndpoint.m}

Expected behavior

should compile perfect

Actual behavior

Duplicate case value 'PJSUA_IP_CHANGE_OP_NULL' Screenshot 2020-02-21 at 18 07 25

{anything else that might be related/useful}

Carolyn65 commented 4 years ago

Same Issue here, doesn't exist with a previous version. Issue seems to be in the switch for the static void onIpChangeProgress method located in the VLSEndpoint.m file in the pod itself as it exists in both the example project and when including the pod in a brand new project.

ChrisKontosEU commented 4 years ago

I cannot see this error. I am running 3.7.0 as a pod on my project and it compiles with no problems. Is your x-code updated? Which version are you running?

mudassirzulfiqar commented 4 years ago

I just cloned the Example Project, and I have noticed that the Example project is not pushed right i guess. As you can see that this variable is being used without defining everywhere.

Screenshot 2020-02-25 at 14 40 27
ChrisKontosEU commented 4 years ago

It is highly possible the example project is broken and needs to be fixed. You can try to fix it and create a pull request if you want.

arjenfvellinga commented 4 years ago

PJSUA_IP_CHANGE_OP_NULL is an addition to PJSIP 2.10, our example app is indeed not updated to use that, but the library code already uses it.

ludivinefafournoux commented 4 years ago

So now, is it not possible to use the example app ?

arjenfvellinga commented 4 years ago

PJSUA_IP_CHANGE_OP_NULL is an addition to PJSIP 2.10, our example app is indeed not updated to use that, but the library code already uses it.

I made an error here, PJSUA_IP_CHANGE_OP_COMPLETED was added in PJSIP 2.10

If I checkout master there is a podfile /Example/Podfile in the example folder saying: 'pod 'VialerSIPLib', :path => '../''

and in /Pod/Classes/VSLEndpoint.m there is a reference to PJSUA_IP_CHANGE_OP_COMPLETED and PJSUA_IP_CHANGE_OP_NULL https://github.com/VoIPGRID/VialerSIPLib/blob/develop/Pod/Classes/VSLEndpoint.m#L904-L928

for me that specific seems correct - not saying there aren't other problems with the example app