VoVAllen / tf-dlpack

DLPack for Tensorflow
Apache License 2.0
36 stars 4 forks source link

support tf1.* ? #10

Closed RanFeng closed 4 years ago

RanFeng commented 4 years ago

it's a wonderful work! i want to know will it support tensorflow 1.. ? thanks for your reply!

VoVAllen commented 4 years ago

Hi,

It's hard to implement this for tf 1.0 since it's based on symbolic execution, which prevents sending PyCapsule between symbols. One possible alternative you can refer to is tobe's implementation with tftvm, which packs the external computation into a custom op.

VoVAllen commented 4 years ago

Although I can see some work around to solve this, but the code would be ugly. Also since tf 1.0 will be gradually deprecated. I'm not considering to implement it on tf1.0.