Add a "Festival" event type

kateabr commented 2 years ago

Add a new celebration-like category for events with free participation and no competitiveness/prizes; like "Character anniversary" but without focus on a particular character.

ycanardeau commented 2 years ago

Can you please make sure that it really makes sense to add a "Festival" event type, rather than having a "Festival" tag for events? Adding a new event type should be done sparingly, same as VocaDB/vocadb#458 and VocaDB/vocadb#792.

And are you planning to make a pull request? I'll transfer this issue to the VocaDB/community repo, which should be handled by the "community". We can reference this issue from the VocaDB/vocadb repo when making a pull request.

CatgirlFrostmoon commented 2 years ago

Can you please make sure that it really makes sense to add a "Festival" event type, rather than having a "Festival" tag for events?

Immediately, I can find these from just a quick search:

As you can see, there's a decent amount of festival-type events out there, and many of them are getting kind of weirdly placed into "contest" instead.

ycanardeau commented 2 years ago

@CatgirlFrostmoon Can you also please explain "why" you need this event type? It's not just a matter of a decent amount of festival-type events. An event type should have some logic in my opinion. If it's just for categorizing purposes only, I'd suggest using a tag. For example, if an artist has the "Vocaloid" artist type, then it also can have a base voicebank, and if a song has the "Cover" song type, then it can have an original version. But of course I'm not against adding a new event type if you can make proper guidelines for event types vs tags.

CatgirlFrostmoon commented 2 years ago

@ycanardeau My big reason for wanting it to be an actual type instead of a tag is that A: it doesn't actually match any of the types we already have, and B: that's causing issues. The various events above are categoried all over the place -- Unspecified, Other, and Contest have all been used. Other is the most accurate, but there's a very clear lack of consensus as to how to categorize these festivals. All of the examples you mentioned are things with actual matching types; there is no matching type for this event (excluding, perhaps, "Other"), leading to an array of categories for the same type of event.

ycanardeau commented 2 years ago

One more thing I want to confirm is that: is it very unlikely that other event types are added in the future? I remembered that there was some discussion about adding a "Birthday" event type before. Currently, the EventCategory enum is a flags enum, and not a value enum for some reason, which means that the number of items is limited to 32 (I think we can safely convert it to a value enum though). Additionally, adding a new event type is super easy, but removing it later on is almost impossible.

CatgirlFrostmoon commented 2 years ago

I have no idea. The "anniversary" event type seems perfect for the birthday event as they're very similar overall -- that's an area where the tags may help, or perhaps description can help differentiate birthdays and anniversaries and character days. I don't feel safe speaking on other potential event types, as who knows what will arise in the future. Still, I do agree that event types should be made only when the need arises -- I just believe that the need for a Festival type is already here.

kateabr commented 2 years ago

I don't think there will be any need to remove it: like CatgirlFrostmoon said, there already is a big number of such events, and there is going to be more of them. Speaking of adding more event types -- apart from the "Festival", all other types seem to be logical and covering most of the events that we currently have -- given that this is a strictly media-oriented database. At least, I can't think of another event type to add right from the top of my head.

And are you planning to make a pull request?

I can try! Is adding a enum value all it takes?

ycanardeau commented 2 years ago

@kateabr @CatgirlFrostmoon The new "Festival" event type is available on the beta site.

kateabr commented 2 years ago

Works!

Edit: also works with event series

VocaDB / community

Add a "Festival" event type #155