search

VocaDB / vocadb

VocaDB is a Vocaloid Database with translated artists, albums, music videos and more.
https://vocadb.net
Other
349 stars 39 forks source link

Song details page: popups don't align with buttons anymore #1042

Closed riipah closed 1 year ago

riipah commented 2 years ago

It used to be that when you click "add to custom list" or "report an error", the popup would align under the button. This still works on TouhouDB, but on VocaDB the popups seem to be just centered.

  1. Open any song page
  2. Click "Report an error"

Expected: popup would align with the button. Actual: popup is centered.

ycanardeau commented 2 years ago

See also https://github.com/VocaDB/vocadb/issues/1041#issuecomment-1012172936.

Do popups need to be aligned with buttons in the first place? In most of the websites I use, popup is just centered. And considering that we migrate to a newer UI library in the future (#851), it might be difficult to emulate this behavior.

riipah commented 2 years ago

It's a good usability feature, so you don't need to move your mouse so much. Click the button, then just move the mouse down a bit. Not mandatory, just nice to have. It's just something that "worked" before, so I decided to report it.

And yeah I agree jQuery UI is outdated. I just really liked the styles. So many websites are using generic Bootstrap styles.

FinnRG commented 1 year ago

Considering the upcoming migration to mantine, I''ll close this issue for now. Mantine doesn't really have a way to align modals in such a way. UX wise, users who want to edit quickly can still use the keboard navigation.