search

VocaDB / vocadb

VocaDB is a Vocaloid Database with translated artists, albums, music videos and more.
https://vocadb.net
Other
318 stars 39 forks source link

Skip/Replace niconico videos when in Playlist mode #1335

Open ghost opened 3 years ago

ghost commented 3 years ago

Is your feature request related to a problem? Please describe. I'm surely not the first person who uses the playlist mode sorted by "latest addition" to check for new songs but something that's really annoying is unskippable flood of niconico links. These video won't play in the embed player and will tell you to go visit niconico in order to reproduce them. This defeats the purpose of the embed playlsit and slows down the playback process depending on how many of these links have been added at once.

Describe the solution you'd like It would be nice having an additional filter that would skip songs containing only niconico sources.

Describe alternatives you've considered There are times a song features both niconico and youtube links but they'll still be considered as niconico video by the player and fail to reproduce properly even though they do have a valid youtube link that can be used in the embed player. If adding additional filtering is a no-no maybe forcing songs to play youtube links over niconico ones would halve the amount of failed playbacks

Additional context Example of niconico video failing to play in Playlist mode image

Shiroizu commented 3 years ago

Maybe entries with the tag embedded-playback-unavailable could be skipped by default.

ghost commented 3 years ago

Would that discern between niconico only and songs with both niconico and youtube sources?

ghost commented 3 years ago

I noticed right now niconico videos in playlist mode don't fail to play but videos won't auto play unless I visit the tab. I can't tell if this is an issue caused by a nico nico script or by my own browser settings considering firefox comes with more severe security settings enabled. For reference I also enabled some of these tweaks. I'll try toggling them and look for changes

edit: It just happened with a youtube video as well so I guess this might be a browser issue edit2: So far the issue only happens when the playlist attempts to play nico nico > nico nico or nico nico > you tube. Youtube > youtube auto plays correctly edit3: It happened again with youtube > nico nico after a series of youtube videos auto playing correctly edit4: I tried reverting all the about:config changes mentioned in my original post but the auto play issue persists

riipah commented 3 years ago

Browsers often limit playback based on domains. VocaDB is unique in the sense that it can play content from multiple domains. So when switching domains (between YouTube and NicoNico), it may require re-authorization from the browser, stopping playback. Not sure what the solution is. These browser restrictions also keep changing. It's a cat-and-mouse game between spammers and browsers, and legit websites like VocaDB are caught in the middle.

Since these two are separate issues (skipping unplayable videos and switching between YouTube/NicoNico), you should make another issue. The solutions are different.