Open FinnRG opened 1 year ago
The current warning coverage is pretty extensive. There are a couple common edit mistakes that could be added as new validation warnings that I could think of:
Song length: PV lengths should match for the same song entry (withing 5s or so). There might me rare edge cases to this.
Ambiguous producer roles: When song entry includes multiple producers (composer/arranger/voice manipulator), and if for one of them the role is specified, the roles should be specified for all of them. All producer roles should be either on default (= not specified) or specified for all of them.
Example where this issue was fixed: https://vocadb.net/Song/ViewVersion/1596757?comparedVersionId=1596485
"Osamu (Voice manipulator), Yunosuke" becomes "Osamu (Voice manipulator), Yunosuke (Composer)"
Album entries do no seem to warn about missing voice synths. I think that could be added too.
@Shiroizu What about tag and event entries? I don't think new users usually edit them, but maybe there are some common editing mistakes that I don't know of. There was also some discussion about restricting tag editing to trusted+ users, to prevent mistakes. Maybe entry warnings could help with that (I don't want to restrict standard users to much, because TouhouDb and UtaiteDb don't have large trusted user groups).
Mentioned by @andreoda on discord:
For the NonInstrumentalSongNeedsVocalists warning, I noticed (at least on TouhouDB) that this triggers even if you already tagged the song as instrumental--I'm not sure if that's a check that can easily be added, but I did find it confusing at first given that the warning explicitly says the tag is needed. Additionally, this warning doesn't really seem as applicable to TouhouDB, since, unlike VocaDB, there's not any particular reason why songs would need to have vocalists. Could/should this warning be removed for TouhouDB alone?
Part of #1450. Validation warnings are a good way to prevent common editing errors. We should add new warnings and update outdated/unspecific warnings. This is especially important for events and tags, where we don't have any warnings.
Current issues regarding validation warnings:
1325
1351
1362
1368
1369
Here are all of our current validation errors:
Songs
Artists
Albums