VocaDB / vocadb

VocaDB is a Vocaloid Database with translated artists, albums, music videos and more.
https://vocadb.net
Other
335 stars 40 forks source link

Lyrics not inherited from parent entry after deleting child entry's lyrics #1674

Open saturclay opened 8 months ago

saturclay commented 8 months ago

Website (required)

VocaDB / UtaiteDB / [TouhouDB] (presumably true of other DBs as well)

Describe the bug (required)

After adding and deleting the lyrics from a song, it no longer inherits the lyrics of the parent version. See here for the song in question.

To Reproduce (optional)

Steps to reproduce the behavior:

  1. Add lyrics for a song where the parent version already has lyrics and save the entry.
  2. Edit the entry again and remove the lyrics.
  3. Even if you revert the entry to before lyrics were added, the lyrics still don't inherit from the parent version.

Checklist (required)

Fill out the checklist. Use strikethroughs or leave fields empty if you don't know or are unable to check/test.

andreoda commented 8 months ago

Normally lyrics should not get removed if they already have some. But if wrong lyrics get added and there is no replacement, it should be possible to remove them at any time. So, the parent entry lyrics should not reappear on the child entry after removing them from it (child entry).

Perhaps there could be a button on the lyrics tab to add the parent entry lyrics.

The issue is that the lyrics appear empty on children entries when in edit mode. The feature only works externally. That is also why a revert does not work on children entries.

saturclay commented 8 months ago

Yeah, I think a "use parent version's lyrics" button on the child version's edit page would be good.

I don't know how often this specific situation will come up (i.e. parent version already has correct lyrics->someone adds incorrect lyrics to child version->incorrect lyrics are removed), but would be good to have the option.