Changing song language does not affect lyrics language - Githubissues

VocaDB / vocadb

VocaDB is a Vocaloid Database with translated artists, albums, music videos and more.

https://vocadb.net

Other

315 stars 39 forks source link

Changing song language does not affect lyrics language #1695

Open szc126 opened 4 months ago

szc126 commented 4 months ago

Website (required)

VocaDB

Describe the bug (required)

Changing song language (Basic info > Language) does not affect lyrics language (Lyrics > Original > Language).

Examples: https://vocadb.net/Song/ViewVersion/1919121 (three languages) https://vocadb.net/Song/ViewVersion/1919091 https://vocadb.net/Song/ViewVersion/1919090 https://vocadb.net/Song/ViewVersion/1919089 https://vocadb.net/Song/ViewVersion/1919088

To Reproduce (optional)

Steps to reproduce the behavior:

Go to the edit page of a song entry that has lyrics.
Change the song language under Basic info.
Save.
See error (the lyrics language has not changed, and the song will still show up in a search by language, under the unchanged lyrics' language)

Expected behavior (optional)

Lyrics language follows song language. The opposite (song language follows lyrics language) already happens instantly in the editor.

Desktop (optional)

OS: Linux
Browser: Firefox 122.0.1

Checklist (required)

Fill out the checklist. Use ~~strikethroughs~~ or leave fields empty if you don't know or are unable to check/test.

[x] Searched VocaDB/vocadb for duplicate issues.
[x] Tested on the beta site.
[ ] Tested on different browsers (e.g. Firefox, Chrome, Safari, Edge).
[ ] Checked in private mode.
[ ] Cleared browser cache and cookies.
[ ] Checked the DevTools console.
[ ] Checked the syslog (mods+ only).

FinnRG commented 4 months ago

This was intentional at the time (https://github.com/VocaDB/vocadb/issues/1408#issuecomment-1548751059) to mimic the frontend fallback, but I guess we can implement a warning or sync them automatically.