VocaDB / vocadb

VocaDB is a Vocaloid Database with translated artists, albums, music videos and more.
https://vocadb.net
Other
348 stars 39 forks source link

Language is not inherited except via lyrics? #1698

Open szc126 opened 8 months ago

szc126 commented 8 months ago

Website (required)

VocaDB

Describe the bug (required)

Song language is not inherited by derivatives, but lyrics language is inherited.

This seems to have been considered in the past in https://github.com/VocaDB/vocadb/issues/1408#issuecomment-1548694205 (Should we automatically add the language for some derived songs? And if so, what types of derived songs imply unmodified language?).

Although no decision seems to have been made(?), the current behavior of inheriting language via a grandparent entry's lyrics language, rather than a parent entry's song language, seems strange.

To Reproduce (optional)

See above

Expected behavior (optional)

Song language is inherited

Additional context (optional)

Add any other context about the problem here.

Checklist (required)

Fill out the checklist. Use strikethroughs or leave fields empty if you don't know or are unable to check/test.

szc126 commented 8 months ago

Other confusing behavior that seems related:

https://beta.vocadb.net/S/125516 displays as Cantonese on the page itself (by inheriting information from the parent entry?), but does not show up in a search for Cantonese (language), since language is not set in the entry itself?

(please tell me if I should open a new issue)