search

VocaDB / vocadb

VocaDB is a Vocaloid Database with translated artists, albums, music videos and more.
https://vocadb.net
Other
349 stars 39 forks source link

Links to other DBs only recognize original songs #1760

Open saturclay opened 6 months ago

saturclay commented 6 months ago

Is your feature request related to a problem? Please describe. (required)

Currently, the first link to an original song on TouhouDB (or, presumably, on UtaiteDB) in the "external links" section will be understood to be the original song, and so its info will be autopopulated in the "original" field. However, this only works with original songs, which doesn't reflect cases where, for instance, you have a voice synth cover of a Touhou arrangement. It seems like this was an intentional choice (see this issue), but only restricting it to original songs seems inadequate.

Describe the solution you'd like. (required)

I would like this feature to be expanded to accommodate any song type, not just originals.

Here's an example entry

  1. Currently, there is an external link to this arrangement, which does not autopopulate the original field.
  2. If you were to change the external link to this original song, then it does autopopulate.

Checklist (required)

Fill out the checklist.

Susko3 commented 6 months ago

It seems like this was an intentional choice (see this issue), but only restricting it to original songs seems inadequate.

I'm guessing that it was limited to original songs to avoid false positives, where a reference URL is really just a reference URL and not the original version. (*)

I'd also like to mention that linking original songs to other databases is a frontend hack. The original version is not understood by the API.

Compare a song with a proper orignal (API) and this song with a touhoudb original (API). Both show an original version on the frontend, but the backend API only has originalVersionId for the former.

The proper fix for this is to not hack in URL → original version conversion, but to just allow linking original versions across databases (possibly by explicitly pasting the desired original URL as a MVP).

image

If (*) is the reason to limit to original songs, then that problem would be solved by using the proper fix: the original version is always intentionally selected.

saturclay commented 6 months ago

@Susko3 That makes a lot of sense, I'd love to see full integration between the databases as a comprehensive fix.