search

VocaDB / vocadb

VocaDB is a Vocaloid Database with translated artists, albums, music videos and more.
https://vocadb.net
Other
349 stars 39 forks source link

Multiple entries: Disallowing setting entries as "Finished" if they got validation warnings #1833

Open andreoda opened 2 weeks ago

andreoda commented 2 weeks ago

Users can set entries as "Finished" even if they have entry warnings.

For example: https://vocadb.net/S/677428 Warning: This entry is missing the following information: Derived songs need to have an original version specified, if it's in the database, or the original needs to be mentioned in notes.

To reduce problems like these, the entries should only be closing as "Draft" status automatically (appear as the only option).

This feature/rule should only set in if the user is a "Regular". "Trusted" users and above should still be able to set entries as "Finished" due to exceptions, for example cover unifier entries.

Susko3 commented 2 weeks ago

What should happen if a regular user tries to edit and save a "Finished" song that has entry warnings?

andreoda commented 2 weeks ago

@Susko3 As of now, nothing happens and everyone can save entries as "Finished" so if this feature gets added, the only options for regular users will be to save as "Draft", the other options will not be available for them as long as entry warnings are still active/appearing. Trusted, mods and admins will be excluded from this rule.

Entries that are set as "Finished" and still have entry warnings are rare. Usually only trusted+ should edit those anyway.

The rule can of course ignore specific entry/validation warnings or entries with specific tags. I have not yet thought about which ones but we can discuss those here.

Susko3 commented 2 weeks ago

So if a regular user tries to edit a forced "Finished" song (set as such by a trusted user), let's say they are fixing a typo in a cover unifier. The entry will "automatically" get downgraded to "Draft". That doesn't seem right to me.

If a trusted user has force-marked a song as finished, regular user edits shouldn't automatically downgrade the entry to draft status.

I think it makes more sense to allow the song to be kept as finished if it already is in such a state.

andreoda commented 2 weeks ago

@Susko3 There is also the option to introduce a rule that all entries with the cover unifier tag do not get the specific entry/validation warnings. For example they would not receive the warning for missing artists if they have the tag "out of scope (cover unifier)".