search

VocaDB / vocadb

VocaDB is a Vocaloid Database with translated artists, albums, music videos and more.
https://vocadb.net
Other
347 stars 39 forks source link

Make disabled user accounts inaccessible to non-Moderators #888

Open dset0x opened 3 years ago

dset0x commented 3 years ago

Is your feature request related to a problem? Please describe. Some users request that their account is deleted. The closest feature to that that we implement is account disabling. However, their account remains accessible via direct link (/User/Details and /Profile).

Describe the solution you'd like These pages should become inaccessible to users who are not Moderators or Admin.

Describe alternatives you've considered Actual account deletion, but I think it's better to avoid deleting users. They might decide to return.

riipah commented 3 years ago

I think the best solution would be to allow access the page of a disabled user, but hide all information on the page (except for moderators). The reason for this is because there might be links to user page.

dset0x commented 3 years ago

Hmm, I'm not sure I see how an empty profile is preferred. I take it that users who want their account deleted want the URL that used to point to their account no longer reveal their name.

riipah commented 3 years ago

Hiding the user's name is more complicated. What happens to links to the user's profile on-side and off-site? On-site we can disable the links, but need to make sure that the name is hidden. I'm just saying it's quite a lot more work that way, changes to many places instead of just one (the user page).

dset0x commented 3 years ago

I don't think redacting links or words from other pages is necessary (at least as part of this issue). Those links would 404, as would external links.

Users are free to edit/delete their own posts before leaving, but editing what others have written (even if it's references to them) is another story.

riipah commented 3 years ago

Google penalizes sites with dead links, those appear as errors in webmaster tools. You want to avoid dead links (links that lead to error pages). It's also bad for user experience. And if you have a link on a page with disabled user's name then the name isn't really hidden, so what's the point?