Vocal crashes if you play an episode that has a url which redirects.

ghost commented 3 years ago

Prerequisites

[x] I have searched the Issues list for open and closed issues and believe this is a unique, currently unreported bug.

Describe the bug

Trying to play episodes which have urls that redirect (to a cdn) causes vocal to crash.

To Reproduce

Steps to reproduce the behavior:

Go to podcast grid.
Click on se-daily podcast.
Scroll down to any episode.
Click play this episode.
The application crashes.

Expected behavior

The episode should start playing.

Screenshots or screen recordings

Video files are not supported recording.mp4.zip

Logs

Relevant part of logs:

[INFO 12:06:39.162297] Player.vala:109: Setting playback URI: https://traffic.libsyn.com/secure/sedaily/2020_07_28_Indent.mp3
[INFO 12:06:39.170394] gpodderClient.vala:511: 0
[INFO 12:06:42.012154] gpodderClient.vala:546: <html><head><title>404 Not Found</title></head><body bgcolor="white"><center><h1>404 Not Found</h1></center><hr><center>nginx/1.14.0 (Ubuntu)</center></body></html>
[INFO 12:06:42.012288] gpodderClient.vala:547: 404
[INFO 12:06:42.012384] gpodderClient.vala:553: Failed to update progress in gpodder.net for Access Control Management with Fouad Matin and Dan Gillespie
[FATAL 12:06:42.013529] [GLib] g_variant_new_object_path: assertion 'g_variant_is_object_path (object_path)' failed
[FATAL 12:06:42.013680] [GLib] g_variant_ref_sink: assertion 'value != NULL' failed
fish: 'com.github.needleandthread.vocal' terminated by signal SIGSEGV (Address boundary error)

Platform Information

Please share as many of the following details as possible:

Linux distrubution: Arch Linux
OS version: 5.7.12-arch1-1
Desktop environment: swaywm

Please check the applicable option below:

[ ] I'm using the latest version from git that I've manually compiled
[ ] I'm using the latest version of the Flatpak, downloaded from Flathub.org
[ ] I'm using the latest version available from AppCenter
[x] I'm using a different version (please note here) : 2.4.2 from https://aur.archlinux.org/packages/vocal-git/

Additional context

Podcast with which it was tested : https://softwareengineeringdaily.com/category/podcast/feed/

opening the podcast file in browser loads redirects to a different url where the episode is served from but trying to play the same episode url (https://traffic.libsyn.com/secure/sedaily/2020_07_28_Indent.mp3) in vocal causes it to crash.

jonafato commented 3 years ago

I'm not able to reproduce this under current master (the player seems to follow redirects with no issue), but when investigating it, I did run into a crash fixed by #469.

nathandyer commented 2 years ago

I can also confirm this is fixed with our new streaming backend. Marking as complete, thanks for your issue report!

VocalPodcastProject / vocal