Vodianoi / QuickPingMod

Do What The F*ck You Want To Public License
3 stars 1 forks source link

[BUG] #115

Closed Kherae closed 6 months ago

Kherae commented 6 months ago

Describe the bug mod prevents right click from removing pins from map To Reproduce enable this mod and no other (will result in bepinex, jotunn and this mod being loaded). load game. right click pin.

Additional context

[Error  : Unity Log] MissingMethodException: Method not found: Minimap/PinData .Minimap.GetClosestPin(UnityEngine.Vector3,single)
Stack trace:
(wrapper dynamic-method) Minimap.DMD<Minimap::RemovePin>(Minimap,Minimap/PinData)
Minimap.RemovePin (UnityEngine.Vector3 pos, System.Single radius) (at <da52c09f594f4a7480000b7420815ba7>:0)
Minimap.OnMapRightClick (UIInputHandler handler) (at <da52c09f594f4a7480000b7420815ba7>:0)
UIInputHandler.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <256a5619bba44d0eb1f0a92f595de63d>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <a01fe238487248d39ba352ec152ec890>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <a01fe238487248d39ba352ec152ec890>:0)
UnityEngine.EventSystems.EventSystem:Update()
astranberg commented 6 months ago

This might be related?

When I press T or G, the item is pinged but no pins are placed in the map. I see this error in the console:

Stack trace:
(wrapper dynamic-method) Minimap.DMD<Minimap::RemovePin>(Minimap,Minimap/PinData)
Minimap.UpdateShoutPins () (at <da52c09f594f4a7480000b7420815ba7>:0)
Minimap.UpdateDynamicPins (System.Single dt) (at <da52c09f594f4a7480000b7420815ba7>:0)
Minimap.Update () (at <da52c09f594f4a7480000b7420815ba7>:0)

[Error  : Unity Log] MissingMethodException: Method not found: Minimap/PinData .Minimap.GetClosestPin(UnityEngine.Vector3,single)
Stack trace:
(wrapper dynamic-method) Minimap.DMD<Minimap::RemovePin>(Minimap,Minimap/PinData)
Minimap.UpdateShoutPins () (at <da52c09f594f4a7480000b7420815ba7>:0)
Minimap.UpdateDynamicPins (System.Single dt) (at <da52c09f594f4a7480000b7420815ba7>:0)
Minimap.Update () (at <da52c09f594f4a7480000b7420815ba7>:0)

[Error  : Unity Log] MissingMethodException: Method not found: Minimap/PinData .Minimap.GetClosestPin(UnityEngine.Vector3,single)
Stack trace:
(wrapper dynamic-method) Minimap.DMD<Minimap::RemovePin>(Minimap,Minimap/PinData)
Minimap.UpdateShoutPins () (at <da52c09f594f4a7480000b7420815ba7>:0)
Minimap.UpdateDynamicPins (System.Single dt) (at <da52c09f594f4a7480000b7420815ba7>:0)
Minimap.Update () (at <da52c09f594f4a7480000b7420815ba7>:0)

I also cannot add pins directly in the map.

The only mods I have installed are:

All via r2modman. On Valheim 0.217.46 (n-23)

Vodianoi commented 6 months ago

Yep, update 0.217.46 (10/04) broke the mod, I'll try to update it during the week if Valheim references are updated too Thank you for reporting !

Kherae commented 6 months ago

it appears fixed with the recent update. other confirmations?

Vodianoi commented 6 months ago

Yep fixed for now