search

VoicenterTeam / vsip

Vuejs wrapper for jssip
5 stars 0 forks source link

Multiple audioContext instances (chrome tab red indicator) #10

Open LG0012 opened 2 years ago

LG0012 commented 2 years ago

Hello there,

It seems like with each call, new audioContext instance is created, and since every single one of them is active, red tab indicator never disappears even when you hand up the call. Also seems like with each call even more memore has been used. I guess need to rethink how to use one instance and handle hand-up when yo have more than one active call, also on some other events such as: ended, failed. image

You can take a look at DevTools WebAudio: image

Any improvements and optimizations on that? :)

https://developer.mozilla.org/en-US/docs/Web/API/AudioContext

It's recommended to create one AudioContext and reuse it instead of initializing a new one each time,
and it's OK to use a single AudioContext for several different audio sources and pipeline concurrently.

Also there is small mistake in the readme file: image Should be getSipOptions

By the way, thanks for this wrapper! :)

Regani commented 2 years ago

Hey @LG0012!

Very nice point, thanks for your comment! We will handle this issue as soon as we can.