search

VolantMQ / volantmq

High-Performance MQTT Server
Apache License 2.0
981 stars 169 forks source link

refactor: remove anonymous field from the config #168

Closed troian closed 4 years ago

troian commented 4 years ago

after successful auth retain auth backend and pass it to connection

codecov[bot] commented 4 years ago

Codecov Report

Merging #168 into master will increase coverage by 1.11%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   49.58%   50.70%   +1.11%     
==========================================
  Files          10       11       +1     
  Lines         972      994      +22     
==========================================
+ Hits          482      504      +22     
  Misses        451      451              
  Partials       39       39
Impacted Files Coverage Δ
subscriber/subscriber.go 0.00% <0.00%> (ø)
auth/manager.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b30f0ee...c38d394. Read the comment docs.

arihantdaga commented 4 years ago

I was wondering if it'll also set the username in case of MQTT5 when we are receiving Auth Packet and connection.onAuth will be called?