search

VolcaTech / cryptoxmas.xyz

Surprise your friends & support charity
https://cryptoxmas.xyz
GNU General Public License v3.0
15 stars 5 forks source link

[UX] Migrate from web3.js to ethers.js #31

Open seichris opened 5 years ago

seichris commented 5 years ago

This is a ✨ Cryptoxmas.xyz bounty✨

Every bounty DAI paid out will be matched as a donation to this Venezuelan Giveth Campaign

Problem

The user should be able to browse NFTs, using a web2 browser.

Proposed solution

Switch from web3.js to ethers.js library.

Prioritization

Its nice UX, but not needed for the launch.

seichris commented 5 years ago

@dakingha69 do you want to look into this?

How much time do you think you need to work on this?

dohaki commented 5 years ago

Should not be that much work to implement. Could look into this end of this week.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 25.0 DAI (25.0 USD @ $1.0/DAI) attached to it as part of the cryptoxmas.xyz fund.

Dobrokhvalov commented 5 years ago

Hey @elemino, as I'm currently updating escrow smart-contract (will update by tomorrow), you can ignore sending and claiming screens. Just connecting to Metamask via ethers and fetching tokens from smart-contract is enough for the scope of this issue :)

gitcoinbot commented 5 years ago

💰 A crowdfund contribution worth 25.00000 DAI (25.0 USD @ $1.0/DAI) has been attached to this funded issue from @ceresstation.💰

Want to chip in also? Add your own contribution here.

Elemino commented 5 years ago

Hello, I will attempt to submit a pull request over the next new two days. Cheers.

gitcoinbot commented 5 years ago

@elemino Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Elemino commented 5 years ago

Hey! Can someone please recommend a minimum viable change that I can start with to test the waters and alert me about dependencies that may be indirectly affected by the change that I should know about? What about security/bug concerns? I'm looking to make a huge leap and dedicate myself entirely to this until bounty ends! I'll have more questions tomorrow.

p.s: I also noticed that Ethers.js is just about to publish a web3 to ethers migration doc. :)

gitcoinbot commented 5 years ago

@elemino Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@elemino Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 25.0 DAI (25.0 USD @ $1.0/DAI) has been submitted by:

  1. @elemino

@Kisgus please take a look at the submitted work:

Elemino commented 5 years ago

Please allow me to send another pr within the next two days. Unless somebody can provide a solution now.

hatgit commented 5 years ago

Hi All, is there another PR that @Elemino is submitting for consideration of the Gitcoin bounty payout? If not, @Kisgus please review Elemino's latest submission and kindly provide an update here. Thanks!

Kisgus commented 5 years ago

Hey @hatgit I believe @Elemino will be submitting a new PR pretty soon, is that correctly understood? Elemino and I have been I dialogue around this on telegram, as he is aware we are now about to merge our codebase with https://github.com/RadiCards/radi.cards which are not using react.js but vue.js.

Elemino commented 5 years ago

Yes. I am still working on this. Will submit PR soon.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 25.0 DAI (plus a crowdfund of 25.0 DAI worth 25.0 USD) (25.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter