search

Volcomix / virtual-background

Demo on adding virtual background to a live video stream in the browser
https://volcomix.github.io/virtual-background
Apache License 2.0
487 stars 124 forks source link

Regression: SIMD support #12

Closed jiangts closed 3 years ago

jiangts commented 3 years ago

Thanks for sharing this amazing project!

I just noticed that SIMD support seems to be broken now. See this console.warn messages image

Not sure if this is related to recent commits updating the tflite version numbers?

jiangts commented 3 years ago

oh, is this a flag that needs to be enabled on the browser side? The SIMD option was available for me on your demo site yesterday, but disappeared today (I didn't touch any flags). Very weird...

EDIT: I just turned on the chrome devflag and SIMD worked for me again. Leaving this open in case you have some insights into the puzzle. Otherwise, feel free to close.

Volcomix commented 3 years ago

Hi @jiangts, thanks a lot for reporting this issue. Indeed Chrome origin trial expired yesterday (May the 19th). I renewed the origin trial in ebf239f55ede070a55b76b86dd667b518dccf448 to fix the issue. SIMD should be back!

jiangts commented 3 years ago

Wow, you are amazing! Very impressed that you were able to compile tflite to wasm and load these models. I got a bit into emscripten compilation learning from https://github.com/ffmpegwasm/ffmpeg.wasm and I've learned a bit more from this repo (not so familiar with bazel yet though).

Volcomix commented 3 years ago

Thanks a lot, I'm glad that you found this project useful! Learning bazel is not very smooth and I also struggled a little bit in the beginning. Building tflite was also tricky, especially because some key configurations are kind of hidden and are kept outside of tensorflow repos. Happy to share them!