Voljega / ExoDOSConverter

a custom game converter from the ExoDOS collection to emulation station based distribution format
151 stars 12 forks source link

added ability for windows to download via Torrent #102

Closed Dreded closed 2 years ago

Dreded commented 2 years ago

100

Made it so windows can use the torrent downloader built in to eXodos, not tested with eXoWin Will try webdownload first and if it fails and is windows will try torrent download.

Dreded commented 2 years ago

just an FYI I probably won't take this further. The windows part is done and should be trivial to add Linux and mac support, you would just need to include or have the user install the aria2c binaries for those systems and change the windows code accordingly.

my thought was for each OS...

the nature of torrent downloads is that they are done in chunks so extra files will be made each time a download occurs so easiest to put these into a folder and delete the entire folder after all games are processed(I didn't do this, I delete it each time above but thats not that expensive)

in an ideal world you would check if a download is needed for any games in the list and then do all the downloading without moving the needed file out of the DOWNLOAD folder all at once(one aria2c call with all games) then when done copy out the needed game zips, delete the DOWNLOAD folder and continue on with life having done all downloads MUCH quicker

Voljega commented 2 years ago

Thank you for this MR too.

yeah I originally wanted to include torrent download through a python client so that I wouldn't have to include binaries and it would be system agnostic, but I never found a good and/or complete bittorrent python client...

Sorry for the long time in reviewing your MRs, I will definitely do it, but as stated before I'm a bit exhausted by my regular developer work, so a bit lazy this days regarding extra code work

And I also made the tragic mistake of installing Elgen Ring ....

Dreded commented 2 years ago

oh no worries about the slow response, I tend to be a bit hasty anyhow so its best to let the commits pile up for a day or two before merging 📦

Totally understand about developer laziness, real reason iv decided not to continue is that I am currently trying to learn C++ and figured doing an all in one converter/downloader/scraper would be a great project as I cannot think of anything else to do and completely fixing the DOS scraping scene seems like a good goal (I'm not very imaginative) so iv just found myself busy trying out different C++ GUI options(its weirdly a crap shoot)