VolkovLabs / volkovlabs-dynamictext-panel

Business Text Panel for @grafana
https://docs.volkovlabs.io
Apache License 2.0
78 stars 14 forks source link

HTML unable to process SVGs #142

Closed ArcherThompson closed 1 year ago

ArcherThompson commented 1 year ago

Issue when using is not recognized and is instead parsed as text

Expected: An example simple svg is shown below:

`

`

this example should render a yellow circle with a green outline in the table

Result: The tag is missed and shows the following as text `

`

SVGS are a pretty nice tool to have for a panel when an image is not realistic to pull in. Would this be realistic to add to support for?

mikhail-vl commented 1 year ago

@ArcherThompson Do you have Sanitize HTML disabled? https://volkovlabs.io/plugins/volkovlabs-dynamictext-panel/content#sanitizing

SVG is displayed correctly on our demo server with Sanitizing disabled.

ArcherThompson commented 1 year ago

@mikhail-vl Ah yes this is almost definitely the issue, I am running this on an instance on Grafana Cloud so I will have to figure out how to do that as its different than a local instance.

Thank you,

mikhail-vl commented 1 year ago

@ArcherThompson We follow best security practices when developing plugins. I think you should contact support to disable sanitizing in Grafana Cloud.

Let us know if there is anything else.