VolmitSoftware / Adapt

Adapt Vanilla Gameplay with better skills and implementations than anywhere else!
https://docs.volmit.com/adapt
Other
85 stars 56 forks source link

Poison Blade Not Respecting PvP Rules in Regions and WorldGuard Flags #407

Closed apollonmeddev closed 1 year ago

apollonmeddev commented 1 year ago

Problem

The Poison Blade adaptation in the Adapt plugin is not respecting PvP rules in regions and WorldGuard flags. Even if PvP is disallowed in a specific region by a WorldGuard flag, the Poison Blade can still damage players or mobs, which is not consistent with the intended behavior. This can lead to unintended consequences such as players being killed in regions where PvP is not allowed, which can negatively impact the gameplay experience.

To reproduce this issue, I have set up a server with the Adapt plugin and configured several regions using WorldGuard to disallow PvP. I then tested the Poison Blade adaptation in these regions and found that it can still damage players and mobs. This is inconsistent with the expected behavior, and the Poison Blade should respect the PvP rules and WorldGuard flags set on the server.

Solution (if any)

No response

Minecraft Version

1.19.2

Adapt Version

Adapt-1.4.20-1.19.2

Log

nothing to show

NextdoorPsycho commented 1 year ago

resolved