VolmitSoftware / Adapt

Adapt Vanilla Gameplay with better skills and implementations than anywhere else!
https://docs.volmit.com/adapt
Other
85 stars 56 forks source link

running pluginid prefixed commands doesn't actually run the command #428

Closed 456dev closed 1 year ago

456dev commented 1 year ago

when running a command like /adapt:adapt, from bukkit's automatic registration of plugin-id:command aliases, the actual command isn't run

expected

running /adapt:adapt to be the same as /adapt

Image Hidden ![image](https://user-images.githubusercontent.com/42748092/235376063-c1f00f5d-834b-4167-8774-345c78fdcf1c.png)

Actual

running /adapt:adapt gives a different result

output (in console since its easier to copy, but same result in-game)

> adapt:adapt
[22:03:17 INFO]: Adapt:class com.volmit.adapt.Adapt:adapt

Log

Full Log ``` Starting org.bukkit.craftbukkit.Main System Info: Java 17 (OpenJDK 64-Bit Server VM 17.0.4+8-Debian-1deb11u1) Host: Linux 5.10.0-20-amd64 (amd64) Loading libraries, please wait... [21:59:05 INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD' [21:59:07 INFO]: Loaded 7 recipes [21:59:08 INFO]: Starting minecraft server version 1.19.4 [21:59:08 INFO]: Loading properties [21:59:08 INFO]: This server is running Paper version git-Paper-519 (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: 936205b) [21:59:08 INFO]: Server Ping Player Sample Count: 12 [21:59:08 INFO]: Using 4 threads for Netty based IO [21:59:08 WARN]: [!] The timings profiler has been enabled but has been scheduled for removal from Paper in the future. We recommend installing the spark profiler as a replacement: https://spark.lucko.me/ For more information please visit: https://github.com/PaperMC/Paper/issues/8948 [21:59:08 INFO]: [ChunkTaskScheduler] Chunk system is using 1 I/O threads, 2 worker threads, and gen parallelism of 2 threads [21:59:09 INFO]: Default game type: SURVIVAL [21:59:09 INFO]: Generating keypair [21:59:09 INFO]: Starting Minecraft server on *:25565 [21:59:09 INFO]: Using epoll channel type [21:59:09 INFO]: Paper: Using libdeflate (Linux x86_64) compression from Velocity. [21:59:09 INFO]: Paper: Using OpenSSL 1.1.x (Linux x86_64) cipher from Velocity. [21:59:09 INFO]: [SpigotLibraryLoader] [Adapt] Loading 8 libraries... please wait [21:59:10 INFO]: [SpigotLibraryLoader] [Adapt] Loaded library /home/the456gamer/projects/minecraft/adapt-testserver/libraries/com/googlecode/concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/concurrentlinkedhashmap-lru-1.4.2.jar [21:59:10 INFO]: [SpigotLibraryLoader] [Adapt] Loaded library /home/the456gamer/projects/minecraft/adapt-testserver/libraries/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar [21:59:10 INFO]: [SpigotLibraryLoader] [Adapt] Loaded library /home/the456gamer/projects/minecraft/adapt-testserver/libraries/com/google/code/gson/gson/2.8.9/gson-2.8.9.jar [21:59:10 INFO]: [SpigotLibraryLoader] [Adapt] Loaded library /home/the456gamer/projects/minecraft/adapt-testserver/libraries/com/elmakers/mine/bukkit/EffectLib/9.4/EffectLib-9.4.jar [21:59:10 INFO]: [SpigotLibraryLoader] [Adapt] Loaded library /home/the456gamer/projects/minecraft/adapt-testserver/libraries/org/bitbucket/mstrobel/procyon-core/0.6.0/procyon-core-0.6.0.jar [21:59:10 INFO]: [SpigotLibraryLoader] [Adapt] Loaded library /home/the456gamer/projects/minecraft/adapt-testserver/libraries/org/bitbucket/mstrobel/procyon-compilertools/0.6.0/procyon-compilertools-0.6.0.jar [21:59:10 INFO]: [SpigotLibraryLoader] [Adapt] Loaded library /home/the456gamer/projects/minecraft/adapt-testserver/libraries/org/bitbucket/mstrobel/procyon-reflection/0.6.0/procyon-reflection-0.6.0.jar [21:59:10 INFO]: [SpigotLibraryLoader] [Adapt] Loaded library /home/the456gamer/projects/minecraft/adapt-testserver/libraries/org/zeroturnaround/zt-zip/1.15/zt-zip-1.15.jar [21:59:10 INFO]: [SpigotLibraryLoader] [Adapt] Loaded library /home/the456gamer/projects/minecraft/adapt-testserver/libraries/org/slf4j/slf4j-api/1.6.6/slf4j-api-1.6.6.jar [21:59:10 INFO]: [Adapt] Loading server plugin Adapt v1.9.2-1.19.4 [21:59:10 INFO]: [LuckPerms] Loading server plugin LuckPerms v5.4.71 [21:59:10 INFO]: Server permissions file permissions.yml is empty, ignoring it [21:59:10 INFO]: [LuckPerms] Enabling LuckPerms v5.4.71 [21:59:10 INFO]: __ [21:59:10 INFO]: | |__) LuckPerms v5.4.71 [21:59:11 INFO]: |___ | Running on Bukkit - Paper [21:59:11 INFO]: [21:59:11 INFO]: [LuckPerms] Loading configuration... [21:59:11 INFO]: [LuckPerms] Loading storage provider... [H2] [21:59:12 INFO]: [LuckPerms] Loading internal permission managers... [21:59:12 INFO]: [LuckPerms] Performing initial data load... [21:59:12 INFO]: [LuckPerms] Successfully enabled. (took 1811ms) [21:59:12 INFO]: Preparing level "world" [21:59:13 INFO]: Preparing start region for dimension minecraft:overworld [21:59:13 INFO]: Time elapsed: 353 ms [21:59:13 INFO]: Preparing start region for dimension minecraft:the_nether [21:59:13 INFO]: Time elapsed: 110 ms [21:59:13 INFO]: Preparing start region for dimension minecraft:the_end [21:59:13 INFO]: Time elapsed: 104 ms [21:59:13 INFO]: [Adapt] Enabling Adapt v1.9.2-1.19.4 [21:59:13 INFO]: [Adapt]: Successfully bound NMS for Version 1.19.4. [21:59:13 INFO]: [Adapt]: Language: en_US - Language Fallback: en_US [21:59:17 INFO]: [Adapt]: █████╗ ██████╗ █████╗ ██████╗ ████████╗ ██╔══██╗██╔══██╗██╔══██╗██╔══██╗╚══██╔══╝ Version: 1.9.2-1.19.4 ███████║██║ ██║███████║██████╔╝ ██║ By: Arcane Arts (Volmit Software) ██╔══██║██║ ██║██╔══██║██╔═══╝ ██║ Java Version: 17 ██║ ██║██████╔╝██║ ██║██║ ██║ ╚═╝ ╚═╝╚═════╝ ╚═╝ ╚═╝╚═╝ ╚═╝ [21:59:18 INFO]: [Adapt]: Checking for updates... [21:59:18 INFO]: [Adapt]: You are running the latest version of Adapt! [21:59:18 INFO]: [GlowingEntities] [GlowingEntities] Found server version 1.19.4 [21:59:18 INFO]: [GlowingEntities] [GlowingEntities] Loaded mappings V1_19 [21:59:19 INFO]: Running delayed init tasks [21:59:19 INFO]: Done (10.638s)! For help, type "help" [21:59:19 INFO]: Timings Reset [22:00:04 INFO]: UUID of player the456gamer is 5f2898b3-b7a0-4ca6-9511-d82c4523505f [22:00:04 INFO]: the456gamer joined the game [22:00:04 INFO]: the456gamer[/127.0.0.1:44688] logged in with entity id 32 at ([world]148.90052299597858, 70.0, 4.977828466246106) [22:00:05 INFO]: [Adapt]: Failed to grant advancement skill_discovery Reattaching! [22:00:53 INFO]: the456gamer issued server command: /adapt [22:00:53 INFO]: [Adapt] [STDOUT] This is the main command for Adapt [22:00:53 WARN]: Nag author(s): '[NextdoorPsycho, Cyberpwn, Vatuu]' of 'Adapt v1.9.2-1.19.4' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger). [22:00:57 INFO]: the456gamer issued server command: /adapt:adapt > adapt:adapt [22:03:17 INFO]: Adapt:class com.volmit.adapt.Adapt:adapt > ```

Probable Cause

https://github.com/VolmitSoftware/Adapt/blob/6fa870536ad9b5fc99617805aa34cbf9ea6b24ed/src/main/java/com/volmit/adapt/util/VolmitPlugin.java#L428-L433