search

VolmitSoftware / React

Smart Server Performance
https://volmit.com
GNU General Public License v3.0
95 stars 52 forks source link

2 Bugs, (Cause Huge TPS Drops) #557

Closed AZFire1 closed 4 years ago

AZFire1 commented 4 years ago

Describe the bug The first bug has to do with the Mob Stacker, it stacks mobs but when you kill them manually it has no drops. Though, if they die like any other mob would it does drop what it's supposed to drop. The second bug has to do with Insta-Breaking blocks and a lot of them at once like Sugar-Cane or Mining Dirt with a High Efficiency Shovel. If you do it enough, the TPS often would drop to 0 - 4 and spike until it suddenly goes back up to 20 as if nothing had happened.

To Reproduce Steps to reproduce the behavior: (Bug 1 Insta Break):

Expected behavior (Bug 1 Insta-Break): I expect for the TPS to suffer until it somehow goes back up to 20 as if nothing had happened (Bug 2 Mob not Dropping Drops on manual death): I expect there to be no drops on the manual kill though for it to drop what it's supposed to on a natural death such as burning.

Screenshots or Video Recordings If applicable, add screenshots or video recordings to help explain your problem. (Bug 1 Insta-Break) https://mega.nz/file/cIgVUYoZ#D2EIpWr-4bJ2B-I-VEsf7btH4gPOUlkg6i1pC5618Vc (Bug 2 Mob not Dropping Drops) https://mega.nz/file/JNBgiajK#Qm91D7XGBo2FQ0KGbm0Vov2NL2l5knrIhBy6N07Jlns

Server and Plugin Informations

Additional context No additional Context

Frerduro commented 4 years ago

We need some timings for the tps issue. Please do /timings on then /timings paste.

AZFire1 commented 4 years ago

It turned out to be the plugin with the name TwerkingCrops. It was messing with a lot in the server. I removed it and it was all fine. Though, I would appreciate if in a couple of the next updates React could possibly have a fix to the stacking system not dropping drops? Other than that, it's all pretty cool. Maybe I just configured it wrong and that's why it's not dropping :)

andythetech commented 4 years ago

Glad to see that the error was found!

I believe that there were many stacking fixes in the most recent updates of React as well.