VolpeUSDOT / RDR-Public

Public Version of the Resilience and Disaster Recovery Tool Suite
Other
6 stars 2 forks source link

Check for use of hard_coded facility_type numbers on links #6

Closed ssmith55 closed 3 months ago

ssmith55 commented 1 year ago

This issue is motivated by discussion with H-GAC. The config file for format_network indicates that centroid_connectors should have facility_type = 11. Some agencies may be using a different facility type for these links. Check if the '11' is hard coded, or can be a configuration item. Same question for the hard coded transit link types of 21,22,23,25 (although the latter may be hardcoded in gtfs2gmns). @kzhang81 , @ssmith55

kzhang81 commented 1 year ago

Thanks @ssmith55 for noting this! The facility_type numbers are currently hard-coded (and if the user is using the default repair cost and time tables, these specific numbers are required). I will make a note of this internally and we can explore creating a more flexible customization of this for users. (As mentioned, we will need to investigate how to adapt the GTFS2GMNS tool as well.)