Volst / ui-components

💎 A React UI component library for Volst.
https://ui-components.volst.nl
10 stars 3 forks source link

Modal: automatically append the modal to `<body>` #8

Closed SpaceK33z closed 6 years ago

SpaceK33z commented 6 years ago

At the moment the <Modal /> component is simply rendered on the place where you decide to render it (which can be in a

with e.g. overflow: hidden;). Because that wouldn't work properly in many cases, our projects have some kind of viewStore.setModal() method, and in the top <App /> component the modal is rendered.

I don't like that at all, because it means more configuration in each project while we also could fix this in ui-components. We could imitate ant.design here (again haha)