search

VoltDB / voltdb-client-go

VoltDB Golang Client Library
MIT License
32 stars 19 forks source link

adds implementation of driver.RowsNextResultSet interface #57

Closed basvanbeek closed 5 years ago

basvanbeek commented 6 years ago

Go's database/sql package supports multiple resultsets.

To enable this feature the driver.RowsNextResultSet interface must be implemented by the database driver. This PR adds the implementation for this.

abradley201 commented 6 years ago

Hi basvanbeek,

If you haven't done so already, please review the CLA on this page: https://github.com/VoltDB/voltdb-client-go/blob/master/CONTRIBUTING.md

Before we merge any commits, all contributors must sign and submit the CLA form to support@voltdb.com. Thank you.

basvanbeek commented 6 years ago

Hi @abradley201, already signed and returned the CLA some time ago. If you look at the repo stats you'll notice there is already contributed code of mine merged previously.

abradley201 commented 6 years ago

Thank you. We will review the code for merging soon. -Andrew

benjaminballard commented 6 years ago

Hi Bas, yes, we're all set on your CLA. We have it on file.

basvanbeek commented 5 years ago

@benjaminballard @abradley201 is there something I can do to expedite this?

basvanbeek commented 5 years ago

@benjaminballard friendly ping... I'd rather use the official package instead of a fork but need this for our production code.

benjaminballard commented 5 years ago

I've asked someone in Engineering to look at this today.