search

VoltServer / uboot-bootcount

Read and reset the u-boot 'bootcount' register on various ARM platforms
GNU General Public License v3.0
2 stars 5 forks source link

Support for i.MX 8M chipsets #8

Closed passgat closed 8 months ago

passgat commented 1 year ago

The series adds bootcount support for the i.MX8M platform (last patch). It also includes rework patches to facilitate the addition of a new platform and two patches to handle the endianness of the bootcount value. I have tested the series on the STM32MP1, am33xx (BeagleBone), and i.MX8M platforms.

passgat commented 10 months ago

Gentle ping.

Thanks, Dario

thom-nic commented 10 months ago

This looks really great, I appreciate the contribution. I'll give a quick manual test on our end and assuming it all works I'll be happy to merge it.

thom-nic commented 10 months ago

@passgat could you provide:

I realized I am missing the same for am33 and mp157 but I intend to add that... I have it here somewhere...

passgat commented 10 months ago

@thom-nic For i.MX8m: I added documentation, list of reference manuals, in the file header of imx8m.c. I added U-Boot configurations (the bootcount address) in the commit message

passgat commented 9 months ago

A gentle ping.

Thanks, Dario

thom-nic commented 9 months ago

@passgat thanks for the reminder. I will try to fit this in soon.

Your contribution looks great of course. I don't have much in the way of feedback w/r/t the i.MX 8 code specifically since I don't have that hardware. I mostly need to build your branch and regression test it for our hw platforms that we use.

passgat commented 9 months ago

I added the imx8m platform because I needed the bootcounnt support for it. So I run tests on this platform. I run tests on the beaglebome (am33xx) and the stm32mp157f-dk2 too, so I don't expect regressions. I don't remember If I run test on eeprom, but I don't think so.

Thanks, Dario

thom-nic commented 9 months ago

That's fine, thank you. I'll do some quick testing on my end so I can merge the PR

passgat commented 9 months ago

Done, I hope I haven't forgotten any tabs.

thom-nic commented 8 months ago

Finally got to testing this on an EEPROM device. Looks great. Thanks for the contribution!

passgat commented 8 months ago

@thom-nic Thank you for having merged the PR. Is it possible to add a tag to release a new version so that I can then update the package in Buildroot?

Thanks and regards Dario

thom-nic commented 8 months ago

@passgat I will do a release. I also really should update the README for IMX8 and STM32MP1 as well..

thom-nic commented 8 months ago

@passgat release created: https://github.com/VoltServer/uboot-bootcount/releases/tag/v3.0.0

passgat commented 8 months ago

@thom-nic Many thanks! Best regards