search

VolumeFi / paloma

The fast blockchain messenger protocol
Apache License 2.0
3 stars 2 forks source link

BUG: User received profit that was different from Profit on MyBots Page #1457

Closed taariq closed 1 month ago

taariq commented 7 months ago

The user experience:

3-19-24 Started at $6,087.87 WBTC (per my Juice Bot dashboard sceenshot) >>> 6,575.36 Etherscan value on trx date. (this is the first issue to recalc)

4-8-24 forgot screenshot but showed $4200 in profit > EXITED BOT at $11,515.30 https://etherscan.io/tx/0xb75f4c5c51a46835c3c957e9cba86caf30a78b23b1a09c641b92a85d198b90c9 $11,515.30 WBTC - $42XX dashboard profit = $7,315.30 >> less 6,575.36 = $739.94 appreciation on principal >> 11.2% appreciation

I roughly calc the estimated BTC appreciation over the same period at 14% so it's close.

It appears the issue may be what the app shows as deposit in my case the $6,087.87 vs Etherscan $6,575.36 value if Etherscan is gospel

fieldtheory123 commented 7 months ago

The $739.94 could be gas estimate. @jamie088 could you confirm if gas is included in pnl calculation and how much it was?

jamie088 commented 7 months ago

The $739.94 could be gas estimate. @jamie088 could you confirm if gas is included in pnl calculation and how much it was?

Yes, I included gas in pnl calculation but I am getting this value from mybots api. fees_charged value in api result. But I don't know this user's bot info because this bot doesn't exist in the open/closed bot list from mybots api. cc: @rootedbox

rootedbox commented 7 months ago

fees_charged is the fee on the transaction it comes from etherscan @jamie088 cc: @verabehr

verabehr commented 6 months ago

@rootedbox the bot is still not showing up in the API, will you please check again?

rootedbox commented 6 months ago

https://service.palomabot.ai/robots?depositor=0x05648018C2F44c1e67d6864FcEa80Fc3154C27e4&completed=true

it's in the API.. created on march 20.. completed 3 days ago

https://etherscan.io/address/0x34bc9970228b14a76ebf0a7f5a601001bbca20c8

jamie088 commented 6 months ago

@rootedbox Please change the fees_charged value (or add a new value) to the USD amount using the ETH price at the time of deposit. (https://discord.com/channels/987730379182051408/1164263785956134992/1228056881520578610)

rootedbox commented 6 months ago

Fixed.. but will only have the right number on new transactions.

verabehr commented 6 months ago

reopening in case @jamie088 needs to do anything else here

verabehr commented 6 months ago

We'll need to test this with a new bot to confirm it is working now as expected

taariq commented 1 month ago

Closing as won't fix.