search

Volumetrics-io / mrjs

An extensible WebComponents library for the Spatial Web
https://mrjs.io
MIT License
160 stars 9 forks source link

`mr-img` should be clipped by `border-radius` on an `mr-div` #282

Open lobau opened 8 months ago

lobau commented 8 months ago

Sample code: https://codepen.io/lobau/pen/ZEPJqxQ

The ᴍʀjs logo is in a mr-div that has border-radius: 16px;. The image is not clipped by the border radius:

image

michaelthatsit commented 8 months ago

@hanbollar would nested masking be a thing?

hanbollar commented 8 months ago

@hanbollar would nested masking be a thing?

we could definitely do it, just wouldnt want to go overboard on using it that's all

for this we can

michaelthatsit commented 6 months ago

I don't think this is currently possible. @hanbollar ?

hanbollar commented 6 months ago

I don't think this is currently possible. @hanbollar ?

not anymore now that we have the current masking system rework setup

it would need to be a featureadd/rework on top

lobau commented 6 months ago

the mrjs website now uses a model instead of an image but we should still consider supporting it similarly as HTML: off by default for performance reasons, but can be enabled by using overflow: hidden like in HTML