Volumetrics-io / mrjs

An extensible WebComponents library for the Spatial Web
https://mrjs.io
MIT License
148 stars 9 forks source link

fix s.t. scales relative to parents even when within `mr-panel` #593

Closed hanbollar closed 2 months ago

hanbollar commented 2 months ago

Linking

Options:

Fixes #592

Problem

mr-panel flattens its children so we can't rely on object3D hierarchy for certain attributes - fixing this for scale, there will be other issues like this in future as well

Solution

add an if-check for if in mr-panel


Required to Merge

After:

https://github.com/Volumetrics-io/mrjs/assets/19377312/e757b821-42dc-406f-86ab-26c8508d2fc8

render[bot] commented 2 months ago

Your Render PR Server URL is https://examples-mrjs-pr-593.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cog4ce779t8c73eqcsgg.