add `loop` and `loopMode` capabilities for AnimationSystem, fix for `comp-audio` to match `comp-anim`: `state`-->`action`

hanbollar commented 2 months ago

Linking

related to:

Problem

loop not implemented for data-comp-animation

Solution

implement it

Breaking Change

YES!!

changes audio state --> action. Made sure this was updated in the documentation repo and the samples here
adds looping for data-comp-animation

Notes

...

Required to Merge

[x] PASS - all necessary actions must pass (excluding the auto-skipped ones)
[x] TEST IN HEADSET - main dev-testing-example and any of the other examples still work as expected
[x] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.

https://github.com/Volumetrics-io/mrjs/assets/19377312/799ab370-5f30-412a-8643-59b4241214c5

[x] TITLE - make sure the pr's title is updated appropriately as it will be used to name the commit on merge
[x] BREAKING CHANGE
- DOCUMENTATION: This includes any changes to html tags and their components
- make a pr in the documentation repo that updates the manual docs to match the breaking change
- link the pr of the documentation repo here: https://github.com/Volumetrics-io/documentation/pull/50
- that pr must be approved by @lobau
- SAMPLES/INDEX.HTML: This includes any changes (html tags or otherwise) that must be done to our landing page submodule as an effect of this pr's updates
- make a pr in the mrjs landing page repo that updates the landing page to match the breaking change
- link the pr of the landing page repo here: #pr
- that pr must be approved by @hanbollar

render[bot] commented 2 months ago

Your Render PR Server URL is https://examples-mrjs-pr-599.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-coo4ia7sc6pc73a8rg90.

michaelthatsit commented 2 months ago

Approved for merge.

I use object.property pretty much everywhere so we miiight need to decide which approach to take across the board for consistency at some point.

hanbollar commented 2 months ago

I use object.property pretty much everywhere so we miiight need to decide which approach to take across the board for consistency at some point.

oh i think object.property is fine most places we have it - i just think this is an edge situation where we need to be very careful of user entry given the multiple options that arent just true/false

Volumetrics-io / mrjs