Description of the problem including potential code and/or screenshots as an example
Solution
Quick explanation of change to be done
Breaking Change
If this is a breaking change describe the before and after and why the change was necessary
Notes
Notes and any associated research or links
Required to Merge
- [ ] PASS - all necessary actions must pass (excluding the auto-skipped ones)
TESTS WILL NOT PASS AFTER THIS PR since this pr is exposing some errors we were missing before --> another pr will follow this that will fix the failures (need to go into mrjs on some things)
[x] TITLE - make sure the pr's title is updated appropriately as it will be used to name the commit on merge
- [ ] BREAKING CHANGE
DOCUMENTATION: This includes any changes to html tags and their components
make a pr in the documentation repo that updates the manual docs to match the breaking change
link the pr of the documentation repo here: #pr
that pr must be approved by @lobau
SAMPLES/INDEX.HTML: This includes any changes (html tags or otherwise) that must be done to our landing page submodule as an effect of this pr's updates
make a pr in the mrjs landing page repo that updates the landing page to match the breaking change
Linking
Fixes #604 related to #602
Problem
Description of the problem including potential code and/or screenshots as an example
Solution
Quick explanation of change to be done
Breaking Change
If this is a breaking change describe the before and after and why the change was necessary
Notes
Notes and any associated research or links
Required to Merge
- [ ] PASS - all necessary actions must pass (excluding the auto-skipped ones)- [ ] TEST IN HEADSET - main dev-testing-example and any of the other [examples](https://github.com/Volumetrics-io/mrjs/tree/main/samples/examples) still work as expected- [ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.- [ ] BREAKING CHANGE@lobau
@hanbollar