Volumetrics-io / mrjs

An extensible WebComponents library for the Spatial Web
https://mrjs.io
MIT License
148 stars 9 forks source link

update: make tests pass again; fixes for lingering small items #607

Closed hanbollar closed 2 months ago

hanbollar commented 2 months ago

Linking

related to #606 Fixes #602 and other things exposed by 606


Required to Merge

render[bot] commented 2 months ago

Your Render PR Server URL is https://examples-mrjs-pr-607.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-copf9nuv3ddc73fob3v0.

hanbollar commented 2 months ago

also found:

weird thing in the images.html example - i think it's a lingering background from something // maybe from the different scaling options where one of the 'quick fix' intermediary backrounds isnt getting deleted --> not sure where that's coming from atm, but not a super big blocker

Screenshot 2024-05-02 at 3 27 57 PM

609

hanbollar commented 2 months ago

lingering notes:

^ this is causing extra errors to occur, for ex: MRSystem not existing, even though it does, just not in the puppeteer setup at that time -- these are only erroring due to an improper testing setup, so commenting it out - to noodle on a little still

going to open an issue based off this to resolve, but not a high priority

hanbollar commented 2 months ago

merging in since this was mostly a testing process fix and like 1 or 2 one-liners