Closed hanbollar closed 2 months ago
Your Render PR Server URL is https://examples-mrjs-pr-607.onrender.com.
Follow its progress at https://dashboard.render.com/static/srv-copf9nuv3ddc73fob3v0.
also found:
weird thing in the images.html example - i think it's a lingering background from something // maybe from the different scaling options where one of the 'quick fix' intermediary backrounds isnt getting deleted --> not sure where that's coming from atm, but not a super big blocker
^ this is causing extra errors to occur, for ex: MRSystem
not existing, even though it does, just not in the puppeteer setup at that time -- these are only erroring due to an improper testing setup, so commenting it out - to noodle on a little still
going to open an issue based off this to resolve, but not a high priority
merging in since this was mostly a testing process fix and like 1 or 2 one-liners
Linking
related to #606 Fixes #602 and other things exposed by 606
Required to Merge
- [ ] TEST IN HEADSET - main dev-testing-example and any of the other examples still work as expected- [ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.- [ ] BREAKING CHANGE@lobau
@hanbollar