Volumetrics-io / mrjs

An extensible WebComponents library for the Spatial Web
https://mrjs.io
MIT License
160 stars 9 forks source link

change all attributes on `<mr-app>` to `data-attributes` #660

Closed hanbollar closed 4 months ago

hanbollar commented 4 months ago

Linking

Fixes https://github.com/Volumetrics-io/mrjs/issues/518

Problem

we dont want to keep having to do this.getattribute('string') since the string part can be faulty

Solution

change everything to a data-attribute - see issue being fixed for more information

Breaking Change

100% yes - documentation, examples, and current live items need to be updated for this change

Notes

...


Required to Merge

render[bot] commented 4 months ago

Your Render PR Server URL is https://examples-mrjs-pr-660.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cp2i4ja0si5c73a9kjt0.

hanbollar commented 4 months ago

@michaelthatsit heads up - i couldnt really test some of the data- attribute changes (most i could visually/through pre-existing examples we had) - adding you on review to do a onceover as well to make sure i didnt miss anything ~


what ive confirmed as working:

what i couldnt confirm but looks right to me: