Closed hanbollar closed 4 months ago
Your Render PR Server URL is https://examples-mrjs-pr-660.onrender.com.
Follow its progress at https://dashboard.render.com/static/srv-cp2i4ja0si5c73a9kjt0.
@michaelthatsit heads up - i couldnt really test some of the data-
attribute changes (most i could visually/through pre-existing examples we had) - adding you on review to do a onceover as well to make sure i didnt miss anything ~
what ive confirmed as working:
data-debug
data-orbital
data-preserve-drawing-buffer
data-stats
data-camera
what i couldnt confirm but looks right to me:
data-lighting
data-occlusion
data-layers
Linking
Fixes https://github.com/Volumetrics-io/mrjs/issues/518
Problem
we dont want to keep having to do
this.getattribute('string')
since the string part can be faultySolution
change everything to a
data-attribute
- see issue being fixed for more informationBreaking Change
100% yes - documentation, examples, and current live items need to be updated for this change
Notes
...
Required to Merge
[ ] VIDEO - if this pr changes something visually - post a video here of it in headset-MR and/or on desktop (depending on what it affects) for the reviewer to reference.@lobau
@hanbollar