Volumetrics-io / mrjs

An extensible WebComponents library for the Spatial Web
https://mrjs.io
MIT License
148 stars 9 forks source link

update mrapp for cleanup and garbage collection #669

Open hanbollar opened 1 month ago

hanbollar commented 1 month ago

Linking

Related to #677 Fixes #678

Problem

Description of the problem including potential code and/or screenshots as an example

Solution

Quick explanation of change to be done

Breaking Change

If this is a breaking change describe the before and after and why the change was necessary


Required to Merge

render[bot] commented 1 month ago

Your Render PR Server URL is https://examples-mrjs-pr-669.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cp40soe3e1ms73choh2g.

hanbollar commented 1 month ago

need to fix 'enter/exit' MR issue - otherwise it's ready to go

hanbollar commented 1 month ago

swapping this back to main since it's not part of the major 'breaking-changes' refactor

hanbollar commented 1 month ago

cant swap - should keep sub-main as itself and then merge that in after this pr since that's still before the big refactor / breaking change