search

VolunteerLiveTeam / Marconi

the VLT stats bot. keeps track of reddit live thread viewers via an influxdb backend.
ISC License
2 stars 1 forks source link

Fix incorrect payload passing #12

Closed markspolakovs closed 6 years ago

markspolakovs commented 6 years ago

I derped, and the webhook was being passed nested payload objects (one from Marconi, another from reddit).

See https://dev.writhem.com/1kxq0xn1?inspect

pironic commented 6 years ago

Whoops...

8/28/2018 3:24:31 PM/srv/dist/Webhooks.js:71 8/28/2018 3:24:31 PM payload: 'payload' in payload ? payload.payload : payload 8/28/2018 3:24:31 PM ^ 8/28/2018 3:24:31 PM 8/28/2018 3:24:31 PMTypeError: Cannot use 'in' operator to search for 'payload' in undefined 8/28/2018 3:24:31 PM at /srv/dist/Webhooks.js:71:44 8/28/2018 3:24:31 PM at Array.forEach () 8/28/2018 3:24:31 PM at Webhooks.sendWebhook (/srv/dist/Webhooks.js:65:21) 8/28/2018 3:24:31 PM at EventEmitter.listener (/srv/dist/Webhooks.js:34:30) 8/28/2018 3:24:31 PM at EventEmitter.emit (/srv/node_modules/eventemitter3/index.js:128:35) 8/28/2018 3:24:31 PM at WebSocket. (/srv/dist/LiveThread.js:53:39) 8/28/2018 3:24:31 PM at emitNone (events.js:105:13) 8/28/2018 3:24:31 PM at WebSocket.emit (events.js:207:7) 8/28/2018 3:24:31 PM at WebSocket.setSocket (/srv/node_modules/ws/lib/WebSocket.js:167:10) 8/28/2018 3:24:31 PM at ClientRequest._req.on (/srv/node_modules/ws/lib/WebSocket.js:715:10) 8/28/2018 3:24:31 PM at emitThree (events.js:135:13) 8/28/2018 3:24:31 PM at ClientRequest.emit (events.js:216:7) 8/28/2018 3:24:31 PM at TLSSocket.socketOnData (_http_client.js:486:11) 8/28/2018 3:24:31 PM at emitOne (events.js:115:13) 8/28/2018 3:24:31 PM at TLSSocket.emit (events.js:210:7) 8/28/2018 3:24:31 PM at addChunk (_stream_readable.js:266:12) 8/28/2018 3:24:31 PM at readableAddChunk (_stream_readable.js:253:11) 8/28/2018 3:24:31 PM at TLSSocket.Readable.push (_stream_readable.js:211:10) 8/28/2018 3:24:31 PM at TLSWrap.onread (net.js:585:20) 8/28/2018 3:24:31 PMnpm info lifecycle marconi-bot@1.0.1~start: Failed to exec start script 8/28/2018 3:24:31 PMnpm ERR! code ELIFECYCLE 8/28/2018 3:24:31 PMnpm ERR! errno 1 8/28/2018 3:24:31 PMnpm ERR! marconi-bot@1.0.1 start: node dist/MonitorCore.js 8/28/2018 3:24:31 PMnpm ERR! Exit status 1 8/28/2018 3:24:31 PMnpm ERR! 8/28/2018 3:24:31 PMnpm ERR! Failed at the marconi-bot@1.0.1 start script. 8/28/2018 3:24:31 PMnpm ERR! This is probably not a problem with npm. There is likely additional logging output above. 8/28/2018 3:24:31 PM 8/28/2018 3:24:31 PMnpm ERR! A complete log of this run can be found in: 8/28/2018 3:24:31 PMnpm ERR! /root/.npm/_logs/2018-08-28T21_24_31_750Z-debug.log