VonC / ghchangelog

Convert GitHub changelog entry to markdown
MIT License
0 stars 0 forks source link

go install github.com/VonC/ghchangelog@latest failing on darwin #1

Open gedw99 opened 2 years ago

gedw99 commented 2 years ago

just wanted to try this out, but got stuck. Did not have time to dig into code yet, so making an issue for now.

go install github.com/VonC/ghchangelog@latest
go: downloading github.com/VonC/ghchangelog v0.2.2
go: downloading github.com/gocolly/colly/v2 v2.1.0
go: downloading github.com/PuerkitoBio/goquery v1.5.1
go: downloading gopkg.in/toast.v1 v1.0.0-20180812000517-0a84660828b2
go: downloading github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
go: downloading golang.org/x/net v0.0.0-20200602114024-627f9648deb9
go: downloading github.com/andybalholm/cascadia v1.2.0
go: downloading github.com/antchfx/htmlquery v1.2.3
go: downloading github.com/antchfx/xmlquery v1.2.4
go: downloading github.com/kennygrant/sanitize v1.2.4
go: downloading github.com/saintfish/chardet v0.0.0-20120816061221-3af4cd4741ca
go: downloading github.com/temoto/robotstxt v1.1.1
go: downloading google.golang.org/appengine v1.6.6
go: downloading github.com/antchfx/xpath v1.1.8
go: downloading github.com/golang/protobuf v1.4.2
go: downloading google.golang.org/protobuf v1.24.0
# gopkg.in/toast.v1
../../../../../../../../pkg/mod/gopkg.in/toast.v1@v1.0.0-20180812000517-0a84660828b2/toast.go:352:41: unknown field 'HideWindow' in struct literal of type syscall.SysProcAttr
gedw99 commented 2 years ago

Ok so the bug is easy

if we change to this toaster we are good: https://github.com/gioui/gio-x/tree/main/notify

for Windows, it uses what your repo already uses: https://github.com/gioui/gio-x/blob/main/notify/notify_windows.go For Darwin, it uses mac specific calls: https://github.com/gioui/gio-x/blob/main/notify/notify_darwin.go

VonC commented 2 years ago

@gedw99 That makes sense since it was already reported (https://github.com/go-toast/toast/issues/14) and https://github.com/go-toast/toast is a go package for Windows 10 toast notifications

I would happily take a PR for using github.com/gioui/gio-x instead. Anyway, thank you for looking into this.