search

Vonage / Grafana_Status_panel

A panel plugin for Grafana to monitor multiple parameters at once
Other
178 stars 108 forks source link

Fix broken links in grafana 6.3.x #151

Closed Pigueiras closed 4 years ago

Pigueiras commented 5 years ago

When you define in a link to open to somewhere, type is not provided anymore in the link parameters so it defaults to undefined all the time, so it opens a non-existing dashboard.

The only parameters provided together with the panel are:

Defaulting the this.uri to link.url fixes the issue

Fixes #133 for at least grafana >= 6.3.x (haven't tried for other versions)

azhiltsov commented 4 years ago

can this be merged?

azhiltsov commented 4 years ago

@Pigueiras I have tried this patch with current master and grafana 6.3.6 It does not seems to work. The panel title from a panel is still pointing to dashboard/undefined But link from the left top corner is working fine.

Pigueiras commented 4 years ago

Mmm, I can't check now but have you tried to put an absolute URL? Especially if you have upgraded grafana from an old version and your dashboard(s) is still using relative dashboard links.

azhiltsov commented 4 years ago

It is an absolute URL, pointing to prometheus in format https://foo.bar.com/bla The dashboard is from older version. I will check what if it newly created.

azhiltsov commented 4 years ago

New panel is behaving the same way.

Pigueiras commented 4 years ago

I'm using Grafana 6.3.2 and I fixed manually this in the grafana machine. If you open /var/lib/grafana/plugins/vonage-status-panel/dist/status_ctrl.js can you see the changed code in the parseUri() function?

azhiltsov commented 4 years ago

@Pigueiras You are right. I forgotten to patch the 'dist' and patched only the 'src' without running grunt. After applying patch to the dist folder it works as it should.

Sorry for the noise and thank you for the help.

DmitryVarlamov commented 4 years ago

Hello, I'm suffering same problems with grafana links Are you going to merge this PR?

arymkus commented 4 years ago

Please merge it =)

abadyan-vonage commented 4 years ago

Thanks for the fix @Pigueiras , sorry for the delay in merging it.