Closed Pigueiras closed 4 years ago
can this be merged?
@Pigueiras I have tried this patch with current master and grafana 6.3.6 It does not seems to work. The panel title from a panel is still pointing to dashboard/undefined But link from the left top corner is working fine.
Mmm, I can't check now but have you tried to put an absolute URL? Especially if you have upgraded grafana from an old version and your dashboard(s) is still using relative dashboard links.
It is an absolute URL, pointing to prometheus in format https://foo.bar.com/bla The dashboard is from older version. I will check what if it newly created.
New panel is behaving the same way.
I'm using Grafana 6.3.2 and I fixed manually this in the grafana machine. If you open /var/lib/grafana/plugins/vonage-status-panel/dist/status_ctrl.js
can you see the changed code in the parseUri()
function?
@Pigueiras You are right. I forgotten to patch the 'dist' and patched only the 'src' without running grunt. After applying patch to the dist folder it works as it should.
Sorry for the noise and thank you for the help.
Hello, I'm suffering same problems with grafana links Are you going to merge this PR?
Please merge it =)
Thanks for the fix @Pigueiras , sorry for the delay in merging it.
When you define in a link to open to somewhere, type is not provided anymore in the link parameters so it defaults to undefined all the time, so it opens a non-existing dashboard.
The only parameters provided together with the panel are:
Defaulting the this.uri to link.url fixes the issue
Fixes #133 for at least grafana >= 6.3.x (haven't tried for other versions)