Vonage / Grafana_Status_panel

A panel plugin for Grafana to monitor multiple parameters at once
Other
180 stars 108 forks source link

Angular is deprecated - please migrate to React #209

Open tolzhabayev opened 1 year ago

tolzhabayev commented 1 year ago

Hello :wave: from Grafana Labs

We have detected that your plugin might still be using AngularJS and recommend migrating it to React, so that it may continue to operate successfully in future versions of Grafana.

You can read more on why and how by visiting our documentation: https://grafana.com/docs/grafana/latest/developers/angular_deprecation/

You can reach out to us with any questions via slack: slack.grafana.com - channel #plugins or our plugin development community forum

floka94 commented 1 year ago

Is the migration finished and ready for usage in Grafana 10?

mvadu commented 11 months ago

@kgullion-vonage can you please create a new release? The currernt latest release is very old, and installing this plugin still pulls that old release into grafana installations.

mvadu commented 11 months ago

tagging @EDDYMENS and @pcroc since only those two are still under Vonage org. I am not sure if other contributors are still active in the company or in github. This plugin still has lots of use, and the code merged as part of #216 hasn't seen the light of day. Could you please generate a new release?

jleafe commented 11 months ago

@floka94, @mvadu - please see @kgullion-vonage's response in this issue.

In your grafana.ini file, allow loading of the plugin:

[plugins]
allow_loading_unsigned_plugins = vonage-status-panel

You can download the zip of the React migration commit here

You can then unzip this plugin to your plugin directory when starting Grafana. There is documentation here on plugin management.

mvadu commented 11 months ago

@jleafe some of us are using managed grafana (e.g. AWS or Azure managed, or grafana cloud) where we simply can't run it in dev mode or control which version of the plugin gets downloaded.

dg-nvm commented 11 months ago

@mvadu It does not have to be in dev mode, it can be just this flag that will allow installation of this specific plugin. But yes if you are using managed Grafana it could be hard to add a plugin that is not in Grafana Repository. If Grafana could self-sign the current version, they technically could do the same for the new one but this option was not presented.

sympatheticmoose commented 11 months ago

Hi there @jleafe @kgullion-vonage @dg-nvm

There might have been a misunderstanding with regards to the signing agreement. There is no cost for community plugins like this to be signed. The referenced issue with Victoria Metrics is due to it being associated with a commercial service and therefore what we would consider a commercial plugin - for which there is a signing fee.

More details can be found in our plugins policy but regardless, we would love to have the updated version of the plugin remain in the catalog and to be enjoyed by users.

Publishing instructions can be found here and if you have any questions please reach out in our community slack or drop an email to integrations@grafana.com

Hope this helps

obrienrobert commented 5 months ago

Has anyone been able to get this workaround to work? https://github.com/Vonage/Grafana_Status_panel/issues/209#issuecomment-1782650403 I can see the unsigned plugin in Grafana (10.4.1) but it still shows Angular as dependency as do the panels in my dashboard even though the version displays 2.0.0: Screenshot 2024-04-11 at 15 56 32

MattWakefieldICE commented 5 months ago

Hi,

Has anyone had any joy with this? Is there anything that can be done to progress the react based version being signed?

As it looks like this is no longer working in Grafana Cloud.