search

Vonage / Grafana_Status_panel

A panel plugin for Grafana to monitor multiple parameters at once
Other
179 stars 109 forks source link

[Feature request] Higher urgency for missing values / threshold for 'No data' #57

Open maxbechtold opened 7 years ago

maxbechtold commented 7 years ago

Hi,

while the Make panel gray when no data option is very useful, it should be applicable on a per metric basis.

So imagine I aggregate 2 metrics Metric A and Metric B in a single Status panel, where there's no data for Metric A, but 'good' values for Metric B.

With Status Panel 1.0.4, the panel turns green. But there are cases (like ours :)) where 'no values' is just as problematic as 'bad values'.

Thus I propose to add an option to the threshold of each metric, e.g. Warning..............90 Critical.............50 Alert 'No data'......✔ Show always..........

This would imply that panels with metrics without data will no longer be green, but gray. Also, the 'gray' metrics would be listed on the panel.

If there are metrics that satisfy the Warning or Critical thresholds, these should probably outrule the no data threshold. To visualize the prioritization Critical > Warning > No data > No threshold met, you could consider switching Warning with Critical in the Threshold section.

What's your opinion?

tomer-amir-vonage commented 7 years ago

Hey @maxbechtold ,

While I see the legitimacy of your use case, we are really trying to keep this plugin simple. for now, we decided to keep this setting global to keep the management of this small plugin from becoming too cumbersome.

You could use the "Disable" function to paint the panel gray. I know it's not the best solution and would require some work on your data source, but at least it will be simial to what you are looking for.

We might change our minds it the future, so keep in touch 😄

vlehm commented 6 years ago

@TomerAmirV, I need exactly the same. For me the main benefit of this plugin is to combine multiple queries in one panel and color accordingly (aggregate the status). As @maxbechtold I need to react on the non-existence of data for one of the queries but currently such a query is simply ignored if there are other queries defined that return values. I thought I could workaround by adding the query twice and use handler type "disable criteria" but it looks like that does not work for "no data" or I don't know what value I have to enter. For me it would be fine to have the "Use 'Disable' color if no data" configuration global, but can't you just change the behaviour so that it already triggers if any of the queries fails to provide data instead of no data at all?