search

Vonage / Grafana_Status_panel

A panel plugin for Grafana to monitor multiple parameters at once
Other
178 stars 108 forks source link

Upcoming Grafana 4.6 will break the Status Panel plugin #81

Closed daniellee closed 6 years ago

daniellee commented 6 years ago

Grafana is going to switch from loading JavaScript files with webpack instead of systemjs:

https://github.com/grafana/grafana/blob/master/PLUGIN_DEV.md

Plugins are still loaded with SystemJS but Grafana will only be exposing predefined classes and will not be allowing access to all parts of Grafana. For the Status Panel plugin, this means: app/plugins/panel/graph/legend and app/plugins/panel/graph/series_overrides_ctrl will no longer be exposed.

The quickest way to fix this is to copy and paste these files into the plugin and adapt them for the Status Panel plugin.

mcinquin commented 6 years ago

Hello,

Can you give us more information about the needed modifications?

Regards.

MarkTurbo commented 6 years ago

Is the Status Panel plugin going to be updated for 4.6? I just started using this panel and after updating to Grafana 4.6.0 today, my dashboards are broken!

YehonatanVonage commented 6 years ago

HI Mark / Shini31, The dashboard is also broken for us in 4.6, we are going to handle this issue soon, and will upload a fixed version.

mcinquin commented 6 years ago

Good news !

FYI, there is already a PR submitted for this issue : https://github.com/Vonage/Grafana_Status_panel/pull/82

daniellee commented 6 years ago

@Shini31 Do you still need more information about the changes? If those classes are needed then I would recommend copying them into the plugin and modifying them to fit.

dudusakharovich commented 6 years ago

@daniellee - Is it also possible to downgrade to previous version and keeping your data sources and dashboards ?

mcinquin commented 6 years ago

@daniellee I don't need more information. I have reverted grafana to 4.5.2. I prefer to wait until the problem is fixed in a future release of status-panel

dudusakharovich commented 6 years ago

@Shini31 - How did you revert it back to 4.5.2 without loosing your data ?

pronichev commented 6 years ago

@dudusakharovich try to run apt-get install grafana=4.5.2 We didn't loose data in our installation after downgrade

mcinquin commented 6 years ago

@dudusakharovich as explained by @pronichev

dudusakharovich commented 6 years ago

@pronichev - I didn't use apt-get, I installed via yum.

mcinquin commented 6 years ago

@dudusakharovich https://access.redhat.com/solutions/64069

dudusakharovich commented 6 years ago

@Shini31 - I received an error while trying to yum history undo:

Loaded plugins: priorities, update-motd, upgrade-helper Undoing transaction 12, from Sun Oct 29 08:55:10 2017 Updated grafana-4.4.3-1.x86_64 @/grafana-4.4.3-1.x86_64 Update 4.6.0-1.x86_64 @/grafana-4.6.0-1.x86_64 Failed to downgrade: grafana-4.4.3-1.x86_64 history undo

pronichev commented 6 years ago

@dudusakharovich You will need the repos containing the old versions of the packages that were updated enabled in order to undo the history. Check /var/log/yum.log for detailed info about error.

armor-devops commented 6 years ago

Any updates on when this fix will go out? Say, as a hotfix?

YehonatanVonage commented 6 years ago

fixed, will be published as version 1.0.6 in the official grafana repository in the following days

portalthiago commented 6 years ago

Hello Guys, any new on this? Thx

sbrandtb commented 6 years ago

@portalthiago version 1.0.6 has been out for a while already: https://grafana.com/plugins/vonage-status-panel