search

Vonage / Grafana_Status_panel

A panel plugin for Grafana to monitor multiple parameters at once
Other
178 stars 108 forks source link

Align with Grafana 4.6.0 plug-in changes #82

Closed PeteBa closed 6 years ago

PeteBa commented 6 years ago

Upgrading to the latest version of Grafana 4.6.0 will render all instances of Status Panel inoperable as access to internal Grafana components has been restricted (see #81). The following error is now shown on any dashboard using this panel:

image

This is due to two imports at the start of status_ctrl.js:

import "app/plugins/panel/graph/legend";
import "app/plugins/panel/graph/series_overrides_ctrl";

It looks like these imports are legacy and no longer referenced within the module. Removing the two lines appears to fix the issue. @TomerAmirV , I have done some initial testing to confirm this works and doesn't break anything obvious but would appreciate if you could double-check and let me know if I've missed something. Happy to follow up as needed.

Also in 4.6.0, the angularjs element \<spectrum-picker> is being depreciated in favour of the new \<color-picker>. This PR updates editor.html to use the new picker. See Grafana Release Notes for further information.

PeteBa commented 6 years ago

Hey, thanks for taking this. I will do a quick rebase of #73 so that it will merge.