Vonage / vivid-3

Vonage's web UI 🎨 toolbelt
https://vivid.deno.dev
Apache License 2.0
51 stars 11 forks source link

[avatar duotone appearance]: additional component appearance #1008

Closed AyalaBu closed 1 year ago

AyalaBu commented 1 year ago

After some research and discussion it was decided that tan additional appearance should be added to the avatar component.

The appearance is used in duotone. Those are link to the design in Figma.

https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/Vivid-UI-Kit---3.0-WIP?node-id=19420%3A158935&t=aevYL5MkqeOU5zho-1

yinonov commented 1 year ago

this should not be worked on as it introduces changes in appearance model. it should be blocked by a ticket that should be opened to apply changes to appearance model. @AyalaBu please reflect those changes in Figma and open a ticket to apply those changes in dev. see VIV-844

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

rachelbt commented 1 year ago

@AyalaBu https://vivid-wykt3m55gccg.deno.dev/components/avatar

AyalaBu commented 1 year ago

@rachelbt Looks great. Does it mean that there will be no more outline avatar?

rachelbt commented 1 year ago

@rachelbt Looks great. Does it mean that there will be no more outline avatar?

I'm leaving this to you to make the investigation :) I understood that it is not needed. but its not me to decide but the designers.

AyalaBu commented 1 year ago

Looks great I still have no answer from the designers about do we need all the appearances

rachelbt commented 1 year ago

as was discusses - we are keeping the outline: https://vonage.slack.com/archives/D03KLBB8K5Y/p1679211223715459