Closed YonatanKra closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
d61b119
) to head (e96201a
). Report is 994 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I found two issues when testing this:
The slider doesn't drag smoothly anymore
Screen.Recording.2024-06-24.at.16.18.10.mov
- Audio player should pause while dragging
Thanks.
@YonatanKra Thanks, first issue is solved.
For the second, it depends on the implementation but most audio players (e.g. native <audio>
in Chrome) pause the audio while being dragged and resume it afterwards. Otherwise you get choppy sound as it is dragged around
change
handler on the slider