Vonage / vivid-3

Vonage's web UI 🎨 toolbelt
https://vivid.deno.dev
Apache License 2.0
51 stars 11 forks source link

[Snackbar / Banner / Toast / Alert] - consolidate and remove redundant features #532

Closed yinonov closed 1 year ago

yinonov commented 2 years ago

Banner

Addresses a scenario where page notifies a user of an important message in an intrusive manner.

Most UX design name the equivalent vivid banner as banner, some call it toast 🤷‍♂️. Most use the role alert internally. some assign log as role

A dismissible element requires programmatic handling of user alert and disruption As Banner is no longer a dismissible element, rather has natural flow display, it might not need that programmatic handling

Snackbar

Addresses a scenario where a page notifies a user of a system occurrences and often requires immediate user attention

Overlaps with Toast

Some library maintainers allow multiple stacked instances

jshenkman commented 2 years ago

Carbon has a good 'Notification pattern' explanation with details on all notification (user feedback) components https://carbondesignsystem.com/patterns/notification-pattern/#notification-types.

By design, their inline alert and pattern look the same, but they have different functionalities

Top is inline and bottom is banner Screen Shot 2022-07-10 at 12 57 30

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

olaf-k commented 1 year ago

reopening as we're still missing one or several component(s) and @AyalaBu is working on that topic.

the Carbon summary @jshenkman linked is a good document to compare to. so here's an attempt:

notes:

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

rinaok commented 1 year ago

@AyalaBu What should we do with this ticket? Are you still working on the design?

AyalaBu commented 1 year ago

@rinaok The design is finished: https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/Vivid-UI-Kit---3.0-WIP?node-id=21271%3A142119&t=DTrdMW2piZjbOokz-1

The component still needs to be migrated.

AyalaBu commented 1 year ago

The issue was moved to JIRA: https://jira.vonage.com/browse/VIV-1009