Vonage / vivid-3

Vonage's web UI 🎨 toolbelt
https://vivid.deno.dev
Apache License 2.0
51 stars 11 forks source link

[sidenav-item]: Icon only #608

Closed rinaok closed 1 year ago

rinaok commented 2 years ago

Description

When there is only an icon in sidenav-item, the hover and the active appearances are with the width of the icon:

https://vivid.deno.dev/components/sidenav-item#icon

Screen Shot 2022-08-08 at 16 46 48

it should be like that:

Screen Shot 2022-08-08 at 16 47 01

Component(s) impacted

sidenav-item

Browser

No response

Vivid Web Components version

latest

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Application/website

vivid

CodeSandbox example

.

Steps to reproduce the issue (if applicable)

hover or click on the sidenav-item with icon only

Release date (if applicable)

No response

Code of Conduct

rachelbt commented 2 years ago

why does an icon-only needs to be full width?

rinaok commented 2 years ago

why does an icon-only needs to be full width?

@rachelbt If you put many sidenav-items inside a sidenav, and one of the sidenav-items is only an icon it look weird.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

yinonov commented 1 year ago

the expectation might be wrong here. perhaps the issue is nav with context being fluid rather than behave as inline and fit its content

rinaok commented 1 year ago

https://jira.vonage.com/browse/VIV-979