Closed yinonov closed 1 year ago
This issue is stale because it has been open for 30 days with no activity.
needs triage
Steps to add popup-polyfill:
npm install @oddbird/popup-polyfill
data-popup
because this feature is still experimental).auto
, hint
, manual
.API
show()
will call showPopup()
and hide()
will call hidePopup()
.Light-dismiss
attribute will apply manual
value to the popup attribute.This issue is stale because it has been open for 30 days with no activity.
This issue was closed because it has been inactive for 14 days since being marked as stale.
The problem
https://github.com/Vonage/vivid-3/blob/b4c9b0af36f787cfc47f13de6a3f144921c5a6be/libs/components/src/lib/popup/README.md?plain=1#L72-L74
Light dismiss implementation in popup isn't sufficient according to the open-ui spec and other explainers - There's more to it than click outside
behavior should support closing when click outside, click on close button, click on anchor, click on escape, resize, scroll etc'.
question: should we add indication on how popup was closed in the fired closing event? such detail on closing exist in a dialog pattern.
see also
_Originally posted by @rinaok in https://github.com/Vonage/vivid-3/pull/676#discussion_r970682471_
https://open-ui.org/components/popup.research (Search page for light dismiss)
https://developer.chrome.com/blog/pop-ups-theyre-making-a-resurgence/
The solution
as native popup seem to gain support and attention, we should adopt a polyfill and set our course towards using the specified interface instead of patching in all its requirements ourselves.
https://github.com/oddbird/popup-polyfill
Business priority
Medium Priority = upcoming release but is not pressing