search

Vonage / vivid-3

Vonage's web UI 🎨 toolbelt
https://vivid.deno.dev
Apache License 2.0
50 stars 11 forks source link

[dialog]: add horizontal position for icon #848

Closed rachelbt closed 1 year ago

rachelbt commented 1 year ago

details are here: https://jira.vonage.com/browse/VIV-825

things to consider:

  1. Currently we have headline and text - we do not have subtitle as shown in the design in Jira: image we do have textmember which is for the content text. If the developer should add content with slot="content" the text will not show up.
  2. the icon is in the graphics slot. Not sure it will cause problem but need to be remembered.
  3. In case the headline is more than one line - is the icon need to be centered like this: image
  4. In the design there are borders to the content - are we adding this to the design? Is it optional? what if there's only headline and footer buttons? This need to have further behaviour options
rachelbt commented 1 year ago

@AyalaBu mind having a look - maybe I am missing something in the Jira issue?

yinonov commented 1 year ago
  1. you're right. dialog does not feature a subtitle in all versions of vivid, but it doesn't block progress of this request.
  2. to apply same size to icon or any other assigned graphic, use internal css variable to assign size value to. that way, icon could refer to it and also authors overriding icon with graphic could refer to it if they need to. it's convenient.
  3. in note, the icon aligns to top. keep the convention
  4. no. it's out of scope of the JIRA ticket
AyalaBu commented 1 year ago

@yinonov @rachelbt This is the link to the newest version of the component: https://www.figma.com/file/r8OYLPmRmDqfLKt6KHdJDB/Vivid-UI-Kit---2.0?node-id=16074%3A74746&t=Un7T3AAxsb6p7yRh-1

The borders mentioned in the ticket function as content dividers in the new component, and even if don't exist right now should be considered, since they organize the content and create hierarchy.

Also, after conversation with Racheli: despite we currently don't have a subtitle in the component, it is still needed and should be developed.

yinonov commented 1 year ago

@AyalaBu these are unrelated to the scope of the JIRA ticket, which is targeted to enable different icon positioning. Let's address, discuss and develop other features against other tickets