Vonage / vivid-3

Vonage's web UI 🎨 toolbelt
https://vivid.deno.dev
Apache License 2.0
51 stars 11 forks source link

[option item]: creating variant with different layout #986

Closed AyalaBu closed 1 year ago

AyalaBu commented 1 year ago

Lately it came to my attention that another option item was created with a different layout:

Image

Image

While having a discussion I said that this is basically and option item, and why not to use something that we already have. The reply was:

  1. That it's less nicer looking with the existing layout
  2. It was already developed
  3. Everyone loves it (?)

So how do we treat this situation?

yinonov commented 1 year ago

That it's less nicer looking with the existing layout

Might be a valid argument. Due that reason alone, it is being considered in vivid.

It was already developed

With no proper research? a wrong process

Everyone loves it (?)

How is this measured? Can the benchmark be shared?

AyalaBu commented 1 year ago

@yinonov @rinaok @rachelbt @YonatanKra @olaf-k

I found a components with somewhat similar layout in the material and angular:

https://mui.com/material-ui/react-checkbox/#label-placement

https://developer.microsoft.com/en-us/fluentui#/controls/web/choicegroup

I guess it is something that can be considered, although it didn't appear in most of design systems I looked at. What are your thoughts about this?

AyalaBu commented 1 year ago

This is the link to branch with the component draft: https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/branch/XvcpSELq5h93tA72JqErzj/Vivid-UI-Kit---3.0-WIP?node-id=19073%3A77181&t=4MpnyNf0dl8EQQiI-1

The component was approved by designers.

These are links that take to a specific frames: Checkbox: https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/branch/XvcpSELq5h93tA72JqErzj/Vivid-UI-Kit---3.0-WIP?node-id=19097%3A81005&t=4MpnyNf0dl8EQQiI-1

Radio: https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/branch/XvcpSELq5h93tA72JqErzj/Vivid-UI-Kit---3.0-WIP?node-id=19097%3A81022&t=4MpnyNf0dl8EQQiI-1

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

rinaok commented 1 year ago

@AyalaBu Can you please open a Jira ticket for this and close it?

AyalaBu commented 1 year ago

Moved to JIRA: https://jira.vonage.com/browse/VIV-954